Review Request 123381: Fallback to AttentionIcon for SNI when animations are disabled
Martin Klapetek
martin.klapetek at gmail.com
Thu Apr 16 11:12:01 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123381/
-----------------------------------------------------------
(Updated April 16, 2015, 1:12 p.m.)
Review request for Plasma.
Changes
-------
Fix typo
Repository: plasma-workspace
Description
-------
This returns the kde4 behavior of simply switching the icon for attention icon when animations are disabled.
I don't think that always using the attention icon with the pulse animation looks good, it looks like there's too much going on. I believe it should be an either-or. So I did it only as a fallback.
Diffs (updated)
-----
applets/systemtray/package/contents/ui/StatusNotifierItem.qml 5380b09
applets/systemtray/package/contents/ui/TaskDelegate.qml f2738bd
Diff: https://git.reviewboard.kde.org/r/123381/diff/
Testing
-------
I didn't test with animations off (I'm not sure how to set) so I just explicitly enabled the timer and disabled the PulseAnimation. Works just like in the old times.
Thanks,
Martin Klapetek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150416/f20ff271/attachment.html>
More information about the Plasma-devel
mailing list