Review Request 123375: give quickshare the SLC capability

[Marco Martin]

> On April 16, 2015, 10:19 a.m., Aleix Pol Gonzalez wrote:
> > applets/quickshare/plasmoid/contents/ui/main.qml, line 228
> > <https://git.reviewboard.kde.org/r/123375/diff/1/?file=361198#file361198line228>
> >
> >     I'm wondering whether we should just always show the document-share icon...?
> >     
> >     Also in case there's something to share, this should probably be specified in the tooltipArea comment...

yeah, may make sense (or the document share icon changing color or something like that


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123375/#review79036
-----------------------------------------------------------


On April 15, 2015, 6:27 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123375/
> -----------------------------------------------------------
> 
> (Updated April 15, 2015, 6:27 p.m.)
> 
> 
> Review request for Plasma and Aleix Pol Gonzalez.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Since as feature/ui-wise the purpose dialog is almost identical to the ui SLC for kde4 had, it makes it quite adapt.
> when an application providing the slc url is open, clicking on it opens the purpose menu for sharing the url
> 
> 
> Diffs
> -----
> 
>   applets/quickshare/plasmoid/contents/ui/ShareDialog.qml 0a5f717 
>   applets/quickshare/plasmoid/contents/ui/main.qml 075434b 
>   applets/quickshare/plugin/CMakeLists.txt 2073c23 
>   applets/quickshare/plugin/contenttracker.h PRE-CREATION 
>   applets/quickshare/plugin/contenttracker.cpp PRE-CREATION 
>   applets/quickshare/plugin/org.kde.ActivityManager.SLC.xml PRE-CREATION 
>   applets/quickshare/plugin/purposeplugin.cpp 23242ee 
> 
> Diff: https://git.reviewboard.kde.org/r/123375/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150416/1b8a9b05/attachment-0001.html>