Review Request 123362: use the new effect for the dashboard

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123362/#review78930
-----------------------------------------------------------

Ship it!



shell/desktopview.cpp (line 170)
<https://git.reviewboard.kde.org/r/123362/#comment53957>

    I'd change to KWindowSystem::setDesktopWhatever(...)
    
    or use ShellCorona API in the if(), having a mix is weird.


- David Edmundson


On April 14, 2015, 4:49 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123362/
> -----------------------------------------------------------
> 
> (Updated April 14, 2015, 4:49 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> since now the show desktop effect is a neat kwin effect, use it instead of the old dashboard that changed the window type on the fly
> 
> 
> Diffs
> -----
> 
>   shell/desktopview.h d47dcd8 
>   shell/desktopview.cpp aec29dc 
>   shell/shellcorona.cpp 4aff26e 
> 
> Diff: https://git.reviewboard.kde.org/r/123362/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150414/fa166ff1/attachment-0001.html>