Review Request 123362: use the new effect for the dashboard

David Edmundson david at davidedmundson.co.uk
Tue Apr 14 17:35:46 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123362/#review78926
-----------------------------------------------------------



shell/desktopview.h 
<https://git.reviewboard.kde.org/r/123362/#comment53954>

    This is currently used
    
    git grep dashboardShown
    desktoppackage/contents/views/Desktop.qml:        visible: desktop.dashboardShown
    desktoppackage/contents/views/Desktop.qml:        value: desktop.dashboardShown ? 0.3 : 1


- David Edmundson


On April 14, 2015, 4:49 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123362/
> -----------------------------------------------------------
> 
> (Updated April 14, 2015, 4:49 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> since now the show desktop effect is a neat kwin effect, use it instead of the old dashboard that changed the window type on the fly
> 
> 
> Diffs
> -----
> 
>   shell/desktopview.h d47dcd8 
>   shell/desktopview.cpp aec29dc 
>   shell/shellcorona.cpp 4aff26e 
> 
> Diff: https://git.reviewboard.kde.org/r/123362/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150414/2c302504/attachment.html>


More information about the Plasma-devel mailing list