Review Request 123332: Timer: Added config ui for notification and title text
Bernhard Friedreich
friesoft at gmail.com
Mon Apr 13 20:00:34 UTC 2015
> On April 13, 2015, 7:40 nachm., David Edmundson wrote:
> > Ship It!
sorry for the misunderstanding but the TextEdits still don't resize to the windowsize.. (see the open issue)
I've just updated the review request with my latest tries about the fillWidth everywhere..
- Bernhard
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123332/#review78905
-----------------------------------------------------------
On April 13, 2015, 7:33 nachm., Bernhard Friedreich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123332/
> -----------------------------------------------------------
>
> (Updated April 13, 2015, 7:33 nachm.)
>
>
> Review request for Plasma.
>
>
> Repository: kdeplasma-addons
>
>
> Description
> -------
>
> Added config ui for specifying a title text
> Added config ui for disabling the notification (default: enabled)
> Added config ui for configuring the notification text
>
>
> Diffs
> -----
>
> applets/timer/package/contents/config/main.xml 886bcd413ff68b4b5b092409dbc5f0e4aff273dc
> applets/timer/package/contents/ui/configAdvanced.qml c315c89249ae5f926c46a901e0358162a067cea4
> applets/timer/package/contents/ui/configAppearance.qml ceb97326b8192a9dfe80b6753c0fd0a7e3010095
> applets/timer/package/contents/ui/timer.qml 82fee524f51f06f522fc8c556a7454ab6840d1a3
>
> Diff: https://git.reviewboard.kde.org/r/123332/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Appearance Config Ui (showing the defaults)
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/11/7628230f-9be6-4c13-b57d-584cb56043bc__tab_appearance_default.png
>
>
> Thanks,
>
> Bernhard Friedreich
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150413/e08da315/attachment-0001.html>
More information about the Plasma-devel
mailing list