Review Request 123337: Use Animator for NeedsAttention pulse animation and make it less noisy

Sebastian K├╝gler sebas at kde.org
Mon Apr 13 12:41:17 UTC 2015



> On April 11, 2015, 10:15 p.m., Martin Klapetek wrote:
> > Do I understand it correctly that now when animations are off, the NeedsAttention state of KSNI will do just nothing? That is seriously bad if that's the case; it should at least fallback to the NeedsAttention icon that the spec defines. It is called "needs attention" after all, it should always do something to get the users attention I believe.
> 
> Kai Uwe Broulik wrote:
>     What did it do before with a zero animation time? Nothing either I suppose?
>     Independently of this we should follow the attention icon either way.

Yeah, if it's not using the proper icon, that needs fixing anyway.

Otherwise, I'm on the edge of disabling this animation along with all others, as it bears specific semantic value. I'd probably keep it if I ruled the world.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123337/#review78838
-----------------------------------------------------------


On April 11, 2015, 7:26 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123337/
> -----------------------------------------------------------
> 
> (Updated April 11, 2015, 7:26 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This significantly reduces CPU stress when a tray icon blinks. Also since we reduced the animation times the pulse became super quick and annoying. It is now hardcoded to 2000s which is a little bit slower than the original one (250 times 6) but it's much more comfortable that way imho. Also turning off "smooth" doesn't really help Animators anyway, and cleanup, alwaysRunToEnd should suffice.
> 
> 
> Diffs
> -----
> 
>   applets/systemtray/package/contents/ui/TaskDelegate.qml 98b15bf 
>   applets/systemtray/package/contents/ui/PulseAnimation.qml 538365d 
> 
> Diff: https://git.reviewboard.kde.org/r/123337/diff/
> 
> 
> Testing
> -------
> 
> Pulsing tray icon no longer causes 10%+ CPU consumption of plasmashell
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150413/e43a3938/attachment-0001.html>


More information about the Plasma-devel mailing list