Review Request 123337: Use Animator for NeedsAttention pulse animation and make it less noisy

Sebastian K├╝gler sebas at kde.org
Mon Apr 13 12:40:19 UTC 2015



> On April 11, 2015, 7:01 p.m., David Edmundson wrote:
> > >It is now hardcoded to 2000s which is a little bit slower than the original one (250 times 6)
> > 
> > Why hardcode instead of longAnimation * 8?
> 
> Kai Uwe Broulik wrote:
>     Originally it used to be 6 * 250, now it's 6 * 120 which is just hyperactive.
> 
> David Edmundson wrote:
>     ah, and you want to avoid it changing again.
>     
>     Makes sense, though I'd maybe have:
>     
>     enabled: units.LongAnimation > 0
>     
>     that way if someone disables animations globally they don't see this?

Maybe make it enbled: units.longAnimation > 1

I don't think we can set units.longAnimation to 0, as that breaks animations left and right (try it). Kai said, using 1 would be enough to fix that, but I haven't verified.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123337/#review78829
-----------------------------------------------------------


On April 11, 2015, 7:26 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123337/
> -----------------------------------------------------------
> 
> (Updated April 11, 2015, 7:26 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This significantly reduces CPU stress when a tray icon blinks. Also since we reduced the animation times the pulse became super quick and annoying. It is now hardcoded to 2000s which is a little bit slower than the original one (250 times 6) but it's much more comfortable that way imho. Also turning off "smooth" doesn't really help Animators anyway, and cleanup, alwaysRunToEnd should suffice.
> 
> 
> Diffs
> -----
> 
>   applets/systemtray/package/contents/ui/TaskDelegate.qml 98b15bf 
>   applets/systemtray/package/contents/ui/PulseAnimation.qml 538365d 
> 
> Diff: https://git.reviewboard.kde.org/r/123337/diff/
> 
> 
> Testing
> -------
> 
> Pulsing tray icon no longer causes 10%+ CPU consumption of plasmashell
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150413/adf0fffa/attachment.html>


More information about the Plasma-devel mailing list