Review Request 123290: Port task manager away from mouse event listener

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123290/#review78885
-----------------------------------------------------------


One correction I read in the description: The initial reason we implemented mouseeventlistener was because we needed something that receives, but doesn't eat the events. MouseEventListener just listens in, but doesn't accept an event, so it can still be consumed by underlying Items.

- Sebastian Kügler


On April 9, 2015, 6:14 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123290/
> -----------------------------------------------------------
> 
> (Updated April 9, 2015, 6:14 p.m.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Bugs: 339482
>     https://bugs.kde.org/show_bug.cgi?id=339482
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> For some reason, MouseEventListener exists because mousearea in qml 1.0 doesn't handle wheel event.
> 
> Now seems it's fine to use Qt5's MouseArea. And it will handle my touch screen event properly. MouseEventListener doesn't call "onReleased" on my touch screen.
> 
> 
> Diffs
> -----
> 
>   applets/taskmanager/package/contents/ui/MouseHandler.qml bbe573e 
>   applets/taskmanager/package/contents/ui/Task.qml 49afaae 
> 
> Diff: https://git.reviewboard.kde.org/r/123290/diff/
> 
> 
> Testing
> -------
> 
> Works like old one.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150413/048a0368/attachment-0001.html>