Review Request 123337: Use Animator for NeedsAttention pulse animation and make it less noisy

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123337/#review78838
-----------------------------------------------------------


Do I understand it correctly that now when animations are off, the NeedsAttention state of KSNI will do just nothing? That is seriously bad if that's the case; it should at least fallback to the NeedsAttention icon that the spec defines. It is called "needs attention" after all, it should always do something to get the users attention I believe.

- Martin Klapetek


On April 11, 2015, 9:26 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123337/
> -----------------------------------------------------------
> 
> (Updated April 11, 2015, 9:26 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This significantly reduces CPU stress when a tray icon blinks. Also since we reduced the animation times the pulse became super quick and annoying. It is now hardcoded to 2000s which is a little bit slower than the original one (250 times 6) but it's much more comfortable that way imho. Also turning off "smooth" doesn't really help Animators anyway, and cleanup, alwaysRunToEnd should suffice.
> 
> 
> Diffs
> -----
> 
>   applets/systemtray/package/contents/ui/TaskDelegate.qml 98b15bf 
>   applets/systemtray/package/contents/ui/PulseAnimation.qml 538365d 
> 
> Diff: https://git.reviewboard.kde.org/r/123337/diff/
> 
> 
> Testing
> -------
> 
> Pulsing tray icon no longer causes 10%+ CPU consumption of plasmashell
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150411/3d08a06c/attachment.html>