Review Request 123337: Use Animator for NeedsAttention pulse animation and make it less noisy

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123337/
-----------------------------------------------------------

(Updated April 11, 2015, 7:16 nachm.)


Review request for Plasma.


Changes
-------

Don't run the animation in the first place when animations are disabled.


Repository: plasma-workspace


Description
-------

This significantly reduces CPU stress when a tray icon blinks. Also since we reduced the animation times the pulse became super quick and annoying. It is now hardcoded to 2000s which is a little bit slower than the original one (250 times 6) but it's much more comfortable that way imho. Also turning off "smooth" doesn't really help Animators anyway, and cleanup, alwaysRunToEnd should suffice.


Diffs (updated)
-----

  applets/systemtray/package/contents/ui/TaskDelegate.qml 98b15bf 
  applets/systemtray/package/contents/ui/PulseAnimation.qml 538365d 

Diff: https://git.reviewboard.kde.org/r/123337/diff/


Testing
-------

Pulsing tray icon no longer causes 10%+ CPU consumption of plasmashell


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150411/302634b4/attachment.html>