Review Request 123273: Image Wallpaper: Don't show duplicates after removing some of the wallpapers

[Antonis Tsiapaliokas]

> On April 6, 2015, 12:56 p.m., Antonis Tsiapaliokas wrote:
> > wallpapers/image/backgroundlistmodel.cpp, line 246
> > <https://git.reviewboard.kde.org/r/123273/diff/1/?file=360275#file360275line246>
> >
> >     I am putting this comment here as an example.
> >     I could either remove this comment before pushing the patch or keeping it as a reference.

Any objections/suggestions about this patch? Should i push it?
It looks kind of an important bug...


- Antonis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123273/#review78558
-----------------------------------------------------------


On April 6, 2015, 12:53 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123273/
> -----------------------------------------------------------
> 
> (Updated April 6, 2015, 12:53 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 345914
>     https://bugs.kde.org/show_bug.cgi?id=345914
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> After removing some local wallpapers, if we click on the apply the remaining wallpapers
> are being shown twice. This patch is fixing this issue.
> 
> In the bug report, there is an image which is showing up the bug after it has been reproduced.
> 
> 
> Diffs
> -----
> 
>   wallpapers/image/backgroundlistmodel.cpp 9aaf514 
> 
> Diff: https://git.reviewboard.kde.org/r/123273/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150411/4629ece6/attachment.html>