Review Request 123332: Timer: Added config ui for notification and title text

[Bernhard Friedreich]

> On April 11, 2015, 3 nachm., David Edmundson wrote:
> > applets/timer/package/contents/ui/configAppearance.qml, line 91
> > <https://git.reviewboard.kde.org/r/123332/diff/1/?file=360828#file360828line91>
> >
> >     use Layout.fillWith: true ?

using QtLayouts.Layout.fillWidth: true doesn't work for me :(
I've set it in all layers I think: the GroupBox, the ColumnLayout, the RowLayout and finally the TextField but it stays small...


> On April 11, 2015, 3 nachm., David Edmundson wrote:
> > applets/timer/package/contents/config/main.xml, line 33
> > <https://git.reviewboard.kde.org/r/123332/diff/1/?file=360827#file360827line33>
> >
> >     Currently there's no way to set these in the UI?
> >     
> >     If there is, we'll have to migrate configs, but if can rely on them always being the current default, then there's no point.

In the current kf5 based qml version of the plasmoid there is no way of setting it in the ui.


- Bernhard


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123332/#review78812
-----------------------------------------------------------


On April 11, 2015, 2:16 nachm., Bernhard Friedreich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123332/
> -----------------------------------------------------------
> 
> (Updated April 11, 2015, 2:16 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Added config ui for specifying a title text
> Added config ui for disabling the notification (default: enabled)
> Added config ui for configuring the notification text
> 
> 
> Diffs
> -----
> 
>   applets/timer/package/contents/config/main.xml 886bcd413ff68b4b5b092409dbc5f0e4aff273dc 
>   applets/timer/package/contents/ui/configAppearance.qml ceb97326b8192a9dfe80b6753c0fd0a7e3010095 
>   applets/timer/package/contents/ui/timer.qml 82fee524f51f06f522fc8c556a7454ab6840d1a3 
> 
> Diff: https://git.reviewboard.kde.org/r/123332/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Appearance Config Ui (showing the defaults)
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/11/7628230f-9be6-4c13-b57d-584cb56043bc__tab_appearance_default.png
> 
> 
> Thanks,
> 
> Bernhard Friedreich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150411/ec9b011d/attachment.html>