Review Request 122884: Use the new KDecoration API for getting additional colors

[Siddhartha Sahu]

> On April 10, 2015, 11:46 a.m., Siddhartha Sahu wrote:
> > Hey. This commit breaks breeze decoration for me. The titlebar is completely black for all windows and also in the "Windows Decoration" kcm list.
> > Titlebar buttons customization also does not work.
> > 
> > Reverting this commit fixes the bug.
> 
> Martin Gräßlin wrote:
>     I rather doubt that this commit can turn it black. Please ensure that you have an up to date build of kwin, too.
> 
> Siddhartha Sahu wrote:
>     Hi Martin,
>     
>     I have plasma 5 built from git using kdesrc-build (updated almost everyday).
>     
>     Just to make sure, I compiled and installed breeze master again. KCM shows black. Revert commit, install, KCM shows everything ok.
> 
> Siddhartha Sahu wrote:
>     Kwin info: https://paste.kde.org/phjgqezjg
> 
> Mika Allan Rauhala wrote:
>     Could you check if ~/.config/kdeglobals has [WM] group? Lack of it might cause DecorationPalette to ignore the color scheme, a good thing with a broken custom color scheme, but not with a default one.
> 
> Mika Allan Rauhala wrote:
>     Could you try https://git.reviewboard.kde.org/r/123320/?
> 
> Thomas Lübking wrote:
>     I assume he's no kdeglobals at all.

I do have kdegloabls, but no WM group in it.
And yes, RR 123320 fixes the bug :)


- Siddhartha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122884/#review78735
-----------------------------------------------------------


On April 1, 2015, 8:55 p.m., Mika Allan Rauhala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122884/
> -----------------------------------------------------------
> 
> (Updated April 1, 2015, 8:55 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> -------
> 
> Breeze::ColorSettings now uses KDecoration2::DecoratedClient::color() for getting additional colors instead of reading them from kdeglobals. This allows per window color schemes with custom titlebar colors to work.
> 
> 
> Diffs
> -----
> 
>   kdecoration/breezecolorsettings.h 40e04fb871f552bf31112d02cad86d286aa416c0 
>   kdecoration/breezecolorsettings.cpp c52bfbe624fc79842f504a586cee20724b176be4 
>   kdecoration/breezedecoration.cpp 175a13d0b0a863e1db99a57b6d82fa254249bb77 
> 
> Diff: https://git.reviewboard.kde.org/r/122884/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mika Allan Rauhala
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150410/ed77c678/attachment.html>