Review Request 122884: Use the new KDecoration API for getting additional colors

Siddhartha Sahu sh.siddhartha at gmail.com
Fri Apr 10 06:16:00 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122884/#review78735
-----------------------------------------------------------


Hey. This commit breaks breeze decoration for me. The titlebar is completely black for all windows and also in the "Windows Decoration" kcm list.
Titlebar buttons customization also does not work.

Reverting this commit fixes the bug.

- Siddhartha Sahu


On April 1, 2015, 8:55 p.m., Mika Allan Rauhala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122884/
> -----------------------------------------------------------
> 
> (Updated April 1, 2015, 8:55 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> -------
> 
> Breeze::ColorSettings now uses KDecoration2::DecoratedClient::color() for getting additional colors instead of reading them from kdeglobals. This allows per window color schemes with custom titlebar colors to work.
> 
> 
> Diffs
> -----
> 
>   kdecoration/breezecolorsettings.h 40e04fb871f552bf31112d02cad86d286aa416c0 
>   kdecoration/breezecolorsettings.cpp c52bfbe624fc79842f504a586cee20724b176be4 
>   kdecoration/breezedecoration.cpp 175a13d0b0a863e1db99a57b6d82fa254249bb77 
> 
> Diff: https://git.reviewboard.kde.org/r/122884/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mika Allan Rauhala
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150410/0b3510cd/attachment.html>


More information about the Plasma-devel mailing list