Review Request 123275: Image Wallpaper: Restore index after removing a wallpaper

[Marco Martin]

> On April 7, 2015, 8:31 a.m., Marco Martin wrote:
> > wallpapers/image/imagepackage/contents/ui/config.qml, line 296
> > <https://git.reviewboard.kde.org/r/123275/diff/1/?file=360286#file360286line296>
> >
> >     hmm, not understanding exactly why the index has to be decremented by count.
> >     shouldn't be just deceremented by 1 iff the removed index is < than currentindex?
> 
> Antonis Tsiapaliokas wrote:
>     No, because if we remove 5 wallpapers instead of 1, then we are still going to point into the wrong wallpaper.
>     Right?
> 
> Marco Martin wrote:
>     shouldn't be done for each wallaper every time, so always 1?
> 
> Marco Martin wrote:
>     any updates on this?
> 
> Antonis Tsiapaliokas wrote:
>     yes, but technically we cannot decrease the index by 1 for each wallpaper,
>     because multiple wallpapers can be deleted at once 
>     And we can only understand how many wallpapers have been deleted.
>     We cannot understand which wallpaper has been deleted and when...

ok, so go for it (closing the bug)


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123275/#review78598
-----------------------------------------------------------


On April 6, 2015, 1:15 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123275/
> -----------------------------------------------------------
> 
> (Updated April 6, 2015, 1:15 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 344384
>     https://bugs.kde.org/show_bug.cgi?id=344384
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> After removing a wallpaper the currentIndex is remaining the same. 
> As a result of that our model has checked the wrong wallpaper.
> This patch is fixing this bug.
> 
> 
> Diffs
> -----
> 
>   wallpapers/image/imagepackage/contents/ui/config.qml 22408ef 
> 
> Diff: https://git.reviewboard.kde.org/r/123275/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150409/926926b7/attachment.html>