Review Request 123303: include FindPackageHandleStandardArgs rather than find it

Harald Sitter sitter at kde.org
Thu Apr 9 08:22:22 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123303/
-----------------------------------------------------------

Review request for Plasma and Aleix Pol Gonzalez.


Repository: kde-gtk-config


Description
-------

FindPackageHandleStandardArgs is a macro include not an actual finder,
find_package actually will refuse to find it anyway, only reason this did
not have adverse effects is supposedly because the GTK3 finder correctly
includes it. it does however falsely report it as missing (what with it
not being found by find_package)


Diffs
-----

  cmake/modules/FindGTK2.cmake 75c2aba933c41f4bbfcb44eb2deaf424064de752 

Diff: https://git.reviewboard.kde.org/r/123303/diff/


Testing
-------

clean cmake && make with all deps installed


Thanks,

Harald Sitter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150409/b5f92cde/attachment.html>


More information about the Plasma-devel mailing list