Review Request 123046: Use own copy of org.kde.JobView.xml
Martin Klapetek
martin.klapetek at gmail.com
Wed Apr 8 22:58:02 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123046/#review78685
-----------------------------------------------------------
Ship it!
Ship It!
- Martin Klapetek
On April 7, 2015, 8:44 p.m., David Rosca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123046/
> -----------------------------------------------------------
>
> (Updated April 7, 2015, 8:44 p.m.)
>
>
> Review request for Plasma, David Edmundson and Martin Klapetek.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Use own copy of org.kde.JobView interface file to make it possible to extend the interface without breaking build (https://git.reviewboard.kde.org/r/122970/)
>
> This also fixes 2 cases where error/errorText would be incorrect in applicationsjob dataengine.
>
>
> Diffs
> -----
>
> dataengines/applicationjobs/CMakeLists.txt e25ff0c
> dataengines/applicationjobs/jobaction.cpp f06977e
> kuiserver/CMakeLists.txt a4fc049
> kuiserver/org.kde.JobView.xml PRE-CREATION
> kuiserver/progresslistmodel.cpp 11fccac
>
> Diff: https://git.reviewboard.kde.org/r/123046/diff/
>
>
> Testing
> -------
>
> build & works fine
>
>
> Thanks,
>
> David Rosca
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150408/271095bd/attachment.html>
More information about the Plasma-devel
mailing list