Review Request 123297: Port dataengine loading to KPluginLoader
Sebastian Kügler
sebas at kde.org
Wed Apr 8 14:48:08 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123297/
-----------------------------------------------------------
Review request for Plasma and Marco Martin.
Repository: plasma-framework
Description
-------
This review contains two commits:
* Look for C++ dataengines first
These are much more common, especially in essential cases. By looking up
the plugins through KPluginLoader first, we can save querying ksycoca.
* Use KPluginLoader to load dataengine
KPluginLoader has all the needed machinery to identify a plugin by its
pluginId. No need to use the query parser here.
Diffs
-----
src/plasma/pluginloader.cpp a5999916b23184f939749b21007722d8ba7ffa54
Diff: https://git.reviewboard.kde.org/r/123297/diff/
Testing
-------
dataengines all load correctly
Thanks,
Sebastian Kügler
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150408/dfd4ac5b/attachment.html>
More information about the Plasma-devel
mailing list