Review Request 123290: Port task manager away from mouse event listener

Marco Martin notmart at gmail.com
Wed Apr 8 08:28:22 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123290/#review78662
-----------------------------------------------------------


just to point out, it's not because of the mouse wheel that it exists (as the name suggests is an event filter to intercept events of the children, just happens to be usable on its own too).
now, i don't know if it was used here for the mouse wheel or for some other difference compared to mousearea
but needs Eike for the final ship it.

- Marco Martin


On April 8, 2015, 5:57 a.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123290/
> -----------------------------------------------------------
> 
> (Updated April 8, 2015, 5:57 a.m.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Bugs: 339482
>     https://bugs.kde.org/show_bug.cgi?id=339482
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> For some reason, MouseEventListener exists because mousearea in qml 1.0 doesn't handle wheel event.
> 
> Now seems it's fine to use Qt5's MouseArea. And it will handle my touch screen event properly. MouseEventListener doesn't call "onReleased" on my touch screen.
> 
> 
> Diffs
> -----
> 
>   applets/taskmanager/package/contents/ui/MouseHandler.qml bbe573e 
>   applets/taskmanager/package/contents/ui/Task.qml 49afaae 
> 
> Diff: https://git.reviewboard.kde.org/r/123290/diff/
> 
> 
> Testing
> -------
> 
> Works like old one.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150408/e48564aa/attachment.html>


More information about the Plasma-devel mailing list