Review Request 123288: Fix some more KConfig usage (wrt bug 340691)

[Hrvoje Senjan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123288/
-----------------------------------------------------------

(Updated April 7, 2015, 6:50 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma, David Edmundson, Eike Hein, and Marco Martin.


Changes
-------

Submitted with commit 1c56fb2195511f4a2e5ff6e94d70dafedb11657e by Hrvoje Senjan to branch master.


Repository: plasma-desktop


Description
-------

We only need to sync the changes to kde4 kdeglobals once users changes the defaults, hence only users KF5 kdeglobals need to be evaluated.
This workarounds (though the change is IMO correct anyway) the kconfig bug, as we can otherwise pass both local and systemwide kdeglobals into copyTo method.


Diffs
-----

  kcms/componentchooser/componentchooserbrowser.cpp f2b81ef 
  kcms/componentchooser/componentchooserterminal.cpp be52334 
  kcms/input/mouse.cpp 69759bd 

Diff: https://git.reviewboard.kde.org/r/123288/diff/


Testing
-------

W/o the patch i had both
BrowserApplication[$e]=chromium-browser.desktop (local adjustement)
BrowserApplication=firefox.desktop (distro branding)

in ~/.kde4/share/config/kdeglobals
now i have only locally adjusted value


Thanks,

Hrvoje Senjan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150407/f72baa2f/attachment.html>