Review Request 123284: Create breeze shadows unconditionally

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123284/
-----------------------------------------------------------

Review request for Plasma and Hugo Pereira Da Costa.


Repository: breeze


Description
-------

Breeze checks if shadows are supported by checking for a property on the
root window. This is set by kwin at some point after startup.

This leaves a gap for apps/plasmashell to start, determine shadows are
not supported and then never render them for the lifespan of that app.

It also can't handle window managers being replaced.

I spoke to Martin Grasslin who suggested just enabling shadows regardless, it's not a lot of overhead to load one set of pixmaps even if we don't end up using it. The alternative is waking up every app every time the root windows prop changes, which is arguably worse longterm.


Diffs
-----

  kstyle/breezeshadowhelper.h d1be0dc 
  kstyle/breezeshadowhelper.cpp 2475076 

Diff: https://git.reviewboard.kde.org/r/123284/diff/


Testing
-------

Logged out and logged back in a lot, plasma always got shadows. Same for session restored apps.

started dolphin under openbox, switched to kwin, shadows \o/


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150407/7a8976d2/attachment.html>