Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution

Tue Apr 7 15:28:43 UTC 2015

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123274/#review78632
-----------------------------------------------------------


A bunch of pedantic comments below


applets/timer/package/contents/config/config.qml (line 32)
<https://git.reviewboard.kde.org/r/123274/#comment53804>

    Rather use "preferences-other"


applets/timer/package/contents/ui/configAdvanced.qml (line 42)
<https://git.reviewboard.kde.org/r/123274/#comment53805>

    "Execute command" (the checkbox already determins 'enabled'), or "Execute the following command:" and then you can save the next label (dunno about HIG here)


applets/timer/package/contents/ui/configAdvanced.qml (line 51)
<https://git.reviewboard.kde.org/r/123274/#comment53806>

    Put the id property first


applets/timer/package/contents/ui/configAppearance.qml (line 29)
<https://git.reviewboard.kde.org/r/123274/#comment53807>

    What is that invisible (flat and no title) GroupBox for?


applets/timer/package/contents/ui/configAppearance.qml (line 43)
<https://git.reviewboard.kde.org/r/123274/#comment53808>

    HIG says Checkboxes should always be positive, ie. "Show seconds" and then enable it by default instead; also makes it consistent with the other one


applets/timer/package/contents/ui/timer.qml (lines 51 - 53)
<https://git.reviewboard.kde.org/r/123274/#comment53816>

    You could just make that a singleton type


applets/timer/plugin/timer.h (line 25)
<https://git.reviewboard.kde.org/r/123274/#comment53810>

    { goes on the next line:
    
    class Foo
    {


applets/timer/plugin/timer.h (line 28)
<https://git.reviewboard.kde.org/r/123274/#comment53809>

    Don't indent "public:"


applets/timer/plugin/timer.h (line 29)
<https://git.reviewboard.kde.org/r/123274/#comment53812>

    Prefer nullptr over 0


applets/timer/plugin/timer.h (line 31)
<https://git.reviewboard.kde.org/r/123274/#comment53811>

    command instead of exe?


applets/timer/plugin/timer.cpp (lines 24 - 25)
<https://git.reviewboard.kde.org/r/123274/#comment53813>

    Braces go on the next line


applets/timer/plugin/timer.cpp (line 27)
<https://git.reviewboard.kde.org/r/123274/#comment53814>

    Braces go on the next line


applets/timer/plugin/timerplugin.h (line 22)
<https://git.reviewboard.kde.org/r/123274/#comment53815>

    That one seems unused


- Kai Uwe Broulik


On April 7, 2015, 3:19 nachm., Bernhard Friedreich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123274/
> -----------------------------------------------------------
> 
> (Updated April 7, 2015, 3:19 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Added tab "General" and "Appearance" in the config ui
> 
> General contains the bits about command execution after the timer has completed
> Appearance contains the ability to hide seconds and showing the title
> 
> The configuration option for showing the title is a bit buggy (again)
> This bugreport explains the wrong scaling of the title: 304923
> 
> I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start)
> 
> [Edit 1]: updated to use QProcess
> [Edit 2]: renamed General to Advanced and moved it down to make "Appearance" the default tab on opening
> [Edit 3]: updated layers in the config ui and make the command textfield depend upon the checkbox
> 
> 
> Diffs
> -----
> 
>   applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f 
>   applets/timer/package/contents/config/config.qml PRE-CREATION 
>   applets/timer/package/contents/ui/configAdvanced.qml PRE-CREATION 
>   applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION 
>   applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 
>   applets/timer/plugin/qmldir PRE-CREATION 
>   applets/timer/plugin/timer.h PRE-CREATION 
>   applets/timer/plugin/timer.cpp PRE-CREATION 
>   applets/timer/plugin/timerplugin.h PRE-CREATION 
>   applets/timer/plugin/timerplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123274/diff/
> 
> 
> Testing
> -------
> 
> Tested using plasmashell directly and using plasmoidviewer
> 
> 
> File Attachments
> ----------------
> 
> Appearance Tab
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/76e6ad91-78e2-4a91-8d2d-99a7ccce41c4__tab_appearance.png
> Advanced Tab
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/e5c1c56e-1109-4d24-9c41-d5f4ffd99d44__tab_advanced.png
> 
> 
> Thanks,
> 
> Bernhard Friedreich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150407/a773e782/attachment-0001.html>