Review Request 123271: improve kickoff representation on vertical panels

Marco Martin notmart at gmail.com
Tue Apr 7 13:03:38 UTC 2015



> On April 7, 2015, 12:59 p.m., Sebastian K├╝gler wrote:
> > So if the panel is horizontal, and high, people get a huge icon. If it's vertical and wide, the icon is limited and centered? That's pretty inconsistent.
> > 
> > I agree that a huge button may not be what the user wants, but then what's huge? Your patch seems to work incidentally, since you have a typo in the code which essentially invalidates the preferred size.
> > 
> > I'd like to see a better thought-through solution for this, as such, I don't find this patch acceptable.

also, it shouldn't have a behavior inconsistent with every other popupapplet icon


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123271/#review78617
-----------------------------------------------------------


On April 6, 2015, 11:40 a.m., Mathias Kraus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123271/
> -----------------------------------------------------------
> 
> (Updated April 6, 2015, 11:40 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> In vertical panels, the kickoff button is huge. This patch limits the size of the kickoff button.
> 
> 
> Diffs
> -----
> 
>   applets/kickoff/package/contents/ui/CompactRepresentation.qml PRE-CREATION 
>   applets/kickoff/package/contents/ui/Kickoff.qml 33b49eb 
> 
> Diff: https://git.reviewboard.kde.org/r/123271/diff/
> 
> 
> Testing
> -------
> 
> see screenshots
> 
> 
> File Attachments
> ----------------
> 
> kickoff-horizontal-before
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/a4848ebd-8dd6-4e46-9f28-ab01fbe13cc6__kickoff-horizontal-before.png
> kickoff-horizontal-after
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b6532939-498e-4c3d-85da-07c0a8162b2f__kickoff-horizontal-after.png
> kickoff-vertical-before
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b71c4d86-dff3-4b2f-a11e-430bc59a732d__kickoff-vertical-before.png
> kickoff-vertical-after
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/55396e5a-1a2d-4523-87f8-4d9cd1d0f067__kickoff-vertical-after.png
> 
> 
> Thanks,
> 
> Mathias Kraus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150407/561793a5/attachment.html>


More information about the Plasma-devel mailing list