Review Request 123275: Image Wallpaper: Restore index after removing a wallpaper
Marco Martin
notmart at gmail.com
Tue Apr 7 08:31:05 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123275/#review78598
-----------------------------------------------------------
wallpapers/image/imagepackage/contents/ui/config.qml (line 296)
<https://git.reviewboard.kde.org/r/123275/#comment53770>
hmm, not understanding exactly why the index has to be decremented by count.
shouldn't be just deceremented by 1 iff the removed index is < than currentindex?
- Marco Martin
On April 6, 2015, 1:15 p.m., Antonis Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123275/
> -----------------------------------------------------------
>
> (Updated April 6, 2015, 1:15 p.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: 344384
> https://bugs.kde.org/show_bug.cgi?id=344384
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> After removing a wallpaper the currentIndex is remaining the same.
> As a result of that our model has checked the wrong wallpaper.
> This patch is fixing this bug.
>
>
> Diffs
> -----
>
> wallpapers/image/imagepackage/contents/ui/config.qml 22408ef
>
> Diff: https://git.reviewboard.kde.org/r/123275/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Antonis Tsiapaliokas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150407/ea0c1066/attachment-0001.html>
More information about the Plasma-devel
mailing list