Review Request 123271: improve kickoff representation on vertical panels
Mark Gaiser
markg85 at gmail.com
Mon Apr 6 17:18:03 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123271/#review78570
-----------------------------------------------------------
Err, i don't see an error in the vertical before version. The kickoff icon simply scales to the new available width, that's how it's supposed to work, right?
I'm not 100% sure. A plasma dev will probably jump in and correct me if i'm wrong :)
- Mark Gaiser
On apr 6, 2015, 11:40 a.m., Mathias Kraus wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123271/
> -----------------------------------------------------------
>
> (Updated apr 6, 2015, 11:40 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> In vertical panels, the kickoff button is huge. This patch limits the size of the kickoff button.
>
>
> Diffs
> -----
>
> applets/kickoff/package/contents/ui/CompactRepresentation.qml PRE-CREATION
> applets/kickoff/package/contents/ui/Kickoff.qml 33b49eb
>
> Diff: https://git.reviewboard.kde.org/r/123271/diff/
>
>
> Testing
> -------
>
> see screenshots
>
>
> File Attachments
> ----------------
>
> kickoff-horizontal-before
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/a4848ebd-8dd6-4e46-9f28-ab01fbe13cc6__kickoff-horizontal-before.png
> kickoff-horizontal-after
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b6532939-498e-4c3d-85da-07c0a8162b2f__kickoff-horizontal-after.png
> kickoff-vertical-before
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b71c4d86-dff3-4b2f-a11e-430bc59a732d__kickoff-vertical-before.png
> kickoff-vertical-after
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/55396e5a-1a2d-4523-87f8-4d9cd1d0f067__kickoff-vertical-after.png
>
>
> Thanks,
>
> Mathias Kraus
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150406/090dc397/attachment-0001.html>
More information about the Plasma-devel
mailing list