Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution

Bernhard Friedreich friesoft at gmail.com
Mon Apr 6 16:38:25 UTC 2015



> On April 6, 2015, 2:29 nachm., David Edmundson wrote:
> > File Attachment: General Tab - tab_general.png
> > <https://git.reviewboard.kde.org/r/123274/#fcomment392>
> >
> >     Given this looks like advanced feature, I'd rather we hid it away so it wasn't the first thing that comes up in the config.
> >     
> >     So I'm clear, what do you see the use case of this being?
> 
> Bernhard Friedreich wrote:
>     Well primarily I readded those configuration options because they were there originally, and looking at the bugreports also used. I guess they got lost in the port to kf5/qml. In the config xml they where still there and I guess some people want them back.
>     
>     Personally I could imagine usecases like custom notifications - e.g. I'll take a short nap of about half an hour - after the timer is done please start playing some music - this could be set as a command I guess.
>     Other ideas instead of command execution? Could we hook something else into this?
>     
>     Your argument about the advanced feature is of course correct - any suggestions? Rename the tab from "General" to "Advanced" (?) and move it down below the "Appearance" so the appearance tab is shown when opening the config dialog?

Regarding the run command usecase: https://bugs.kde.org/show_bug.cgi?id=264934#c1


- Bernhard


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123274/#review78560
-----------------------------------------------------------


On April 6, 2015, 4:05 nachm., Bernhard Friedreich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123274/
> -----------------------------------------------------------
> 
> (Updated April 6, 2015, 4:05 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Added tab "General" and "Appearance" in the config ui
> 
> General contains the bits about command execution after the timer has completed
> Appearance contains the ability to hide seconds and showing the title
> 
> The configuration option for showing the title is a bit buggy (again)
> This bugreport explains the wrong scaling of the title: 304923
> 
> I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start)
> 
> [Edit 1]: updated to use QProcess
> [Edit 2]: renamed General to Advanced and moved it down to make "Appearance" the default tab on opening
> 
> 
> Diffs
> -----
> 
>   applets/timer/plugin/timerplugin.cpp PRE-CREATION 
>   applets/timer/plugin/timer.cpp PRE-CREATION 
>   applets/timer/plugin/timerplugin.h PRE-CREATION 
>   applets/timer/plugin/timer.h PRE-CREATION 
>   applets/timer/plugin/qmldir PRE-CREATION 
>   applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 
>   applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION 
>   applets/timer/package/contents/ui/configAdvanced.qml PRE-CREATION 
>   applets/timer/package/contents/config/config.qml PRE-CREATION 
>   applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f 
> 
> Diff: https://git.reviewboard.kde.org/r/123274/diff/
> 
> 
> Testing
> -------
> 
> Tested using plasmashell directly and using plasmoidviewer
> 
> 
> File Attachments
> ----------------
> 
> Appearance Tab
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b9a4c7dd-c272-4b4c-807b-145102e17d13__tab_appearance.png
> Advanced Tab
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/ca6d1f98-70fe-4d13-a170-ec44cb82bce4__tab_advanced.png
> 
> 
> Thanks,
> 
> Bernhard Friedreich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150406/cff5b15b/attachment.html>


More information about the Plasma-devel mailing list