Review Request 123272: improve digital clock representation on vertical panels

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123272/#review78557
-----------------------------------------------------------



File Attachment: clock-vertical-after2 - clock-vertical-after2.png
<https://git.reviewboard.kde.org//r/123272/#fcomment389>

    As you can see here, the date is now cramped to the burger menu; that's because of the "height:" change; that one should not be there


- Martin Klapetek


On April 6, 2015, 1:55 p.m., Mathias Kraus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123272/
> -----------------------------------------------------------
> 
> (Updated April 6, 2015, 1:55 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> On vertical panels, the date of the digital clock doesn't fit on the panel. This patch sets the size of the date label to fit the panel.
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 74ffac1 
> 
> Diff: https://git.reviewboard.kde.org/r/123272/diff/
> 
> 
> Testing
> -------
> 
> see screenshots
> 
> 
> File Attachments
> ----------------
> 
> clock-horizontal-before1
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/23b26092-8a78-41c5-af9c-4f8ce6abc782__clock-horizontal-befor1.png
> clock-horizontal-after1
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/7898603f-037f-4fcf-b219-db095a167be5__clock-horizontal-after1.png
> clock-horizontal-before2
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/f22e29d7-9fcd-4a3c-8d46-859d4f3fbe3e__clock-horizontal-befor2.png
> clock-horizontal-after2
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/3d189422-5929-44c2-b8a3-7b5470833390__clock-horizontal-after2.png
> clock-vertical-before1
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/8b870753-d2e9-437b-adf8-dce8dba8b49e__clock-vertical-before1.png
> clock-vertical-after1
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/f1eef7c8-b02b-41bc-8c91-10fe778dae73__clock-vertical-after1.png
> clock-vertical-before2
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/3939f8f4-f618-438f-b908-c72861286004__clock-vertical-before2.png
> clock-vertical-after2
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/fa52c342-96d7-4176-83ea-37eb76e31910__clock-vertical-after2.png
> 
> 
> Thanks,
> 
> Mathias Kraus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150406/2e260098/attachment.html>