Review Request 123251: Kicker is notifying KAMD of the recently started applications

[Ivan Čukić]

> On April 4, 2015, 3:44 p.m., Eike Hein wrote:
> > This won't catch launches from the favorites sidebar or the Recent Applications model. You either have to add more hooks there, or you could actually hook into RecentApplications::addApp for now, which is what all the other models' appLaunched() signals are connected to. When I port Recent Applications to KAMD after 5.3, I'll refactor and addApp() turns into something that solely does that KActivities call.

Hmh, this was kinda intentional - though, again something that is not necessarily a good idea.

Namly, if something is in the favs, there is no reason to show it in the recent ones as well - it will be just redundant.

On the other hand, not adding something to the statistics, spoils the statistics.

I'll take whichever approach you think is more fitting.


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123251/#review78487
-----------------------------------------------------------


On April 4, 2015, 8:56 a.m., Ivan Čukić wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123251/
> -----------------------------------------------------------
> 
> (Updated April 4, 2015, 8:56 a.m.)
> 
> 
> Review request for Plasma, Eike Hein and Marco Martin.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> The collected data can be used to show the recently started applications.
> 
> The uri is applications:menuId, as specified by applications KIO.
> 
> 
> Diffs
> -----
> 
>   applets/kicker/CMakeLists.txt d96c34e 
>   applets/kicker/plugin/appsmodel.cpp 03b666a 
> 
> Diff: https://git.reviewboard.kde.org/r/123251/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Čukić
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150404/3b6fdd20/attachment.html>