Review Request 123131: Port kio_man away from kdelibs4support

[David Faure]

> On March 25, 2015, 9:54 p.m., Lukáš Tinkl wrote:
> > man/kio_man.cpp, line 242
> > <https://git.reviewboard.kde.org/r/123131/diff/1/?file=356605#file356605line242>
> >
> >     Not correct, this returns only user configured list of languages, whereas it previously returned the full list.
> 
> Nick Shaforostoff wrote:
>     please see https://projects.kde.org/projects/kde/kdesdk/lokalize/repository/revisions/master/entry/src/common/languagelistmodel.cpp for the ways to get a list of all languages (there is a KDE-way and Qt-way)
> 
> Alex Richardson wrote:
>     So if I parse this correctly the KDE way is: `KConfig(QLatin1String("locale/kf5_all_languages"), KConfig::NoGlobals, QStandardPaths::GenericDataLocation).groupList()`?
>     Should there be something in KI18n or is this sufficiently rare that we can just add "@deprecated use `KConfig(QLatin1String("locale/kf5_all_languages"), KConfig::NoGlobals, QStandardPaths::GenericDataLocation).groupList()` instead" to KLocale::languageList()?

Sounds to me like it should be a method in ki18n, it's a bit too arcane to be maintainable.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123131/#review78048
-----------------------------------------------------------


On March 25, 2015, 9:17 p.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123131/
> -----------------------------------------------------------
> 
> (Updated March 25, 2015, 9:17 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Martin Koller.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> Port kio_man away from kdelibs4support
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 02ae89f2524324f758450ad368f64849e39b2f7d 
>   man/CMakeLists.txt cb4585a289d3f69b8a16429ce87bfce115d1cc27 
>   man/kio_man.cpp e8cf2d70c50c4c20adbb5a81a6213175d397b76e 
>   man/kmanpart.cpp 3af7fc182806e8b89297e8de884ce611c827e881 
>   man/man2html.cpp 3c493ba334bce890b450d7b11ab00c6e783708d4 
> 
> Diff: https://git.reviewboard.kde.org/r/123131/diff/
> 
> 
> Testing
> -------
> 
> man view in kdevelop5 works
> 
> Not sure about the `KLocale::global()->languageList();` -> `QLocale().uiLanguages();` change though so I would like some feedback.
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150404/bec54014/attachment-0001.html>