Review Request 123227: Consider visualParent rotation in popupPosition
Marco Martin
notmart at gmail.com
Thu Apr 2 14:53:20 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123227/
-----------------------------------------------------------
(Updated April 2, 2015, 2:53 p.m.)
Status
------
This change has been discarded.
Review request for Plasma.
Bugs: 345787
http://bugs.kde.org/show_bug.cgi?id=345787
Repository: plasma-framework
Description
-------
if there are transforms in the scene, to correctly compute the position the transpfrm is needed to be accounter for.
QQuickITem::mapRectToScene does consider tranforms.
this adresses bug 345787 where the toolbox may be rotated.
a test is added
Diffs
-----
src/plasmaquick/dialog.cpp cdf78eb
tests/dialog_positioning_parentrotated.qml PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/123227/diff/
Testing
-------
Thanks,
Marco Martin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150402/dc04a488/attachment.html>
More information about the Plasma-devel
mailing list