Review Request 123227: Consider visualParent rotation in popupPosition

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123227/#review78408
-----------------------------------------------------------


+1.

I'd suggest not merging until after 5.9 is tagged given how finicky dialog tends to be.

- David Edmundson


On April 2, 2015, 2 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123227/
> -----------------------------------------------------------
> 
> (Updated April 2, 2015, 2 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 345787
>     http://bugs.kde.org/show_bug.cgi?id=345787
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> if there are transforms in the scene, to correctly compute the position the transpfrm is needed to be accounter for.
> QQuickITem::mapRectToScene does consider tranforms.
> this adresses bug 345787 where the toolbox may be rotated.
> a test is added
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/dialog.cpp cdf78eb 
>   tests/dialog_positioning_parentrotated.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123227/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150402/37be9f81/attachment.html>