Review Request 123222: Fix assert by not calling onto an empty path for setOfflineWebApplicationCachePath()

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123222/#review78398
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On April 2, 2015, 11:13 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123222/
> -----------------------------------------------------------
> 
> (Updated April 2, 2015, 11:13 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: libksysguard
> 
> 
> Description
> -------
> 
> If we pass an empty string, we end up asserting here:
> qt5/qtwebkit/Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:372
> 
> #0  0x00007fffed178512 in WTFCrash () at /home/kde-devel/frameworks/qt5/qtwebkit/Source/WTF/wtf/Assertions.cpp:345
> #1  0x00007fffec78e161 in WebCore::ApplicationCacheStorage::setCacheDirectory (this=0xa07a70, cacheDirectory=...) at /home/kde-devel/frameworks/qt5/qtwebkit/Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:372
> #2  0x00007fffeb5085c5 in QWebSettings::setOfflineWebApplicationCachePath (path="") at /home/kde-devel/frameworks/qt5/qtwebkit/Source/WebKit/qt/Api/qwebsettings.cpp:1142
> #3  0x00007ffff79087bd in ScriptingHtmlDialog::ScriptingHtmlDialog (this=0x969720, parent=0x744080) at /home/kde-devel/frameworks/libksysguard/processui/scripting.cpp:64
> 
> So we just don't set an empty string.
> 
> 
> Diffs
> -----
> 
>   processui/scripting.cpp a0efd69 
> 
> Diff: https://git.reviewboard.kde.org/r/123222/diff/
> 
> 
> Testing
> -------
> 
> Now I don't get a crash anymore.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150402/ded04af2/attachment.html>