Review Request 123220: kfontinst: Fix font list view header alignment and item sizehint

[Daniel Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123220/
-----------------------------------------------------------

(Updated April 2, 2015, 11:33 a.m.)


Review request for Plasma.


Repository: plasma-desktop


Description
-------

I'm not sure the Qt::TextAlignmentRole is even needed (I think it would be better if the KCM obeyed whathever is the current theme default), but it should at least be centered vertically. I guess this wasn't so obvious with Oxygen, but Breeze makes the missing vertical alignment really obvious.

For the SizeHint role, relying on size of a particular random icon if we have a standard method for retrieving default icon size sounds wrong to me. For some reason my system refuses to load dialog-ok icon (so SmallIcon("dialog-ok").size() was returning QSize(0, 0)), which caused all items in the view to have SizeHint QSize(0, 4), making it KCM basically unusable.


Diffs (updated)
-----

  kcms/kfontinst/kcmfontinst/FontList.cpp 802b383 
  kcms/kfontinst/kcmfontinst/GroupList.cpp 4532c0d 

Diff: https://git.reviewboard.kde.org/r/123220/diff/


Testing
-------


Thanks,

Daniel Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150402/dd9ac7ae/attachment.html>