Review Request 123211: Ask for confirmation before deleting a wallpaper.

[Thomas Pfeiffer]

> On April 1, 2015, 4:13 nachm., Thomas Pfeiffer wrote:
> > I agree with Kai: Asking for confirmation in this case is not the approach we should take.
> > What this definitely calls for is an undo function, which should certainly not be impossible to do.
> > 
> > Asking for confirmation should only be the last resort if undoing an action is simply not possible (e.g. when deleting a file permanently). A confirmation adds another step to the 99% of actions that were intentional, only to protect from the 1% accidents.
> > Undo, on the other hand, doesn't bother users in 99% of the cases while helping them in the 1%.
> > 
> > Yes, an undo feature may sound overblown in this case, but we must get into the habit of moving away from confirmation dialogs and towards undo.

Also, please add usability to review requests that contain a significant user interface / interaction element in the future.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123211/#review78354
-----------------------------------------------------------


On April 1, 2015, 3:27 nachm., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123211/
> -----------------------------------------------------------
> 
> (Updated April 1, 2015, 3:27 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 338729
>     https://bugs.kde.org/show_bug.cgi?id=338729
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This patch is adding a confirmation dialog which is being called before we remove a wallpaper.
> 
> 
> Diffs
> -----
> 
>   wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml aee2d3f 
>   wallpapers/image/imagepackage/contents/ui/config.qml 2108082 
> 
> Diff: https://git.reviewboard.kde.org/r/123211/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> dialog
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/01/5bfd2d7c-8baa-4b80-ad20-0844aafdb3a9__deletion_dialog.png
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150401/e2197305/attachment-0001.html>