Review Request 120426: Avoid text rendering outside toolbox frame when dragging from corner -> edge
David Edmundson
david at davidedmundson.co.uk
Mon Sep 29 19:43:42 UTC 2014
> On Sept. 29, 2014, 5:33 p.m., Marco Martin wrote:
> > I'm fine with this one, so ok if goes in, tough i was wondering about an alternative approach..
> > the explicit pause animation looks a bit hacky, i wonder if it would look better using instead the qml state machine? (so that in the state transition there could be a single sequential animation between the frame size and the label opacity) it may be overkill tough
Yeah, I agree.
I did this because it was a smaller change and less likely to break anything.
If I end up having to change toolbox in the future I'll give it a tidy up with states.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120426/#review67642
-----------------------------------------------------------
On Sept. 29, 2014, 5:17 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120426/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2014, 5:17 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> Avoid text rendering outside toolbox frame when dragging from corner -> edge
>
>
> Diffs
> -----
>
> toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml 35f35f1
>
> Diff: https://git.reviewboard.kde.org/r/120426/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140929/f1f8bcb8/attachment.html>
More information about the Plasma-devel
mailing list