Review Request 120424: Fix kde4breeze affecting Qt4 apps on clean installations

Marco Martin notmart at gmail.com
Mon Sep 29 15:51:37 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120424/#review67634
-----------------------------------------------------------

Ship it!


Inviala!

- Marco Martin


On Set. 29, 2014, 3:40 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120424/
> -----------------------------------------------------------
> 
> (Updated Set. 29, 2014, 3:40 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> -------
> 
> (commit 1)
> 
> Create kde4 config if it does not exist
> 
> If there is no KDE4 directory and KDEHOME is not set. Kdelibs4Migration
> returns an empty path.
> 
> For most usecases this is fine as it means there is nothing to import
> however in our unusual case we are writing data so we should manually
> create it.
> 
> BUG: 338422
> 
> --
> 
> (commit 2)
> Remove check for hasWidgetStyle
> 
> This was needed when using QtCurve.
> Now we are using Breeze we know fully well we have it installed as it's
> in the same repo.
> 
> 
> Diffs
> -----
> 
>   misc/kde4breeze/src/main.cpp b8fedac 
> 
> Diff: https://git.reviewboard.kde.org/r/120424/diff/
> 
> 
> Testing
> -------
> 
> unset KDEHOME
> mv .kde4 myOldHome ; /opt/kde5/lib64/kconf_update_bin/kde4breeze
> 
> 
> checked .kde4/share/config/kdeglobals had some stuff in it.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140929/da9d7f1f/attachment-0001.html>


More information about the Plasma-devel mailing list