Review Request 120386: Fix Apply button in applet configuration

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120386/
-----------------------------------------------------------

(Updated Sept. 29, 2014, 12:24 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Bugs: 339428
    https://bugs.kde.org/show_bug.cgi?id=339428


Repository: plasma-desktop


Description
-------

There's no need to call restoreConfiguration() in Component.onCompleted since the explicit manipulation of the StackView's sourceFile property in said method will already trigger the onSourceFileChanged handler which will restoreConfigration() also.

This lead to the issue that for data structures QML cannot compare, like the Array of extra items in systray config, triggered the change handler on re-assignment by the method running a second time enabling the Apply button.


Diffs
-----

  desktoppackage/contents/configuration/AppletConfiguration.qml 2da918e 

Diff: https://git.reviewboard.kde.org/r/120386/diff/


Testing
-------

Opened config, changed and applied values, switched between pages, in systray and digitalclock config. Config restored properly.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140929/81758a7e/attachment.html>