Review Request 120396: Port the PowerDevil runner

Hrvoje Senjan hrvoje.senjan at gmail.com
Sun Sep 28 17:40:23 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120396/
-----------------------------------------------------------

(Updated Sept. 28, 2014, 5:40 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Vishesh Handa.


Repository: plasma-workspace


Description
-------

i really don't suspend as i used to - otherwise i'd ported it already :D for me most used runner other than service one in 4.x plasma. kdelibs4support is needed due to Solid/Powermanagement usage


Diffs
-----

  runners/CMakeLists.txt 20488a8 
  runners/powerdevil/CMakeLists.txt 55ae806 
  runners/powerdevil/PowerDevilRunner.h f070701 
  runners/powerdevil/PowerDevilRunner.cpp 7c27d9c 

Diff: https://git.reviewboard.kde.org/r/120396/diff/


Testing
-------

builds, 'sleep' appears in results and correctly suspends.
2 caveats:
a) (not limited to this runner) it isn't enabled by default somehow
b) the 'sleep' result is IMO too low on list, maybe Vishesh knows why


Thanks,

Hrvoje Senjan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140928/17220139/attachment.html>


More information about the Plasma-devel mailing list