Review Request 120407: Show application title if SNI does not provide a tooltip

[David Edmundson]

> On Sept. 28, 2014, 4:13 p.m., David Edmundson wrote:
> > applets/systemtray/plugin/protocols/dbussystemtray/dbussystemtraytask.cpp, line 439
> > <https://git.reviewboard.kde.org/r/120407/diff/1/?file=315614#file315614line439>
> >
> >     this looks wrong.
> >     otherwise if you have a title and a subtitle we'll always set it to the subtitle
> >     
> >     else if?
> 
> Kai Uwe Broulik wrote:
>     I don't see anything wrong with it.
>     The ifs are just for only emitting the signal when it actually changed.
>     
>     title ? tooltip title
>     subtitle ? tooltip text

I read this as setting m_tooltipTitle twice.

Ignore me


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120407/#review67566
-----------------------------------------------------------


On Sept. 28, 2014, 4:06 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120407/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2014, 4:06 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 337710
>     https://bugs.kde.org/show_bug.cgi?id=337710
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Since the SNI spec does not requires you to provide a tooltip, this patch makes the tooltip show the application icon and name in case no tooltip is provided. This also restores Plasma 4.x behavior afaict.
> 
> 
> Diffs
> -----
> 
>   applets/systemtray/plugin/protocols/dbussystemtray/dbussystemtraytask.cpp 14458e9 
> 
> Diff: https://git.reviewboard.kde.org/r/120407/diff/
> 
> 
> Testing
> -------
> 
> - Plugged in and out SD card, devicenotifier updated its icon accordingly
> - Mousewheel'd kmix, tooltip text was updated properly
> - Steam tooltip now has icon and text
> 
> 
> File Attachments
> ----------------
> 
> Steam tooltip
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/09/28/ebd6683d-b47b-4c06-9cc2-afbbfd8da57a__steamtooltip.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140928/dd2e7ea5/attachment.html>