Review Request 120358: DigitalClock: Add timezone information to digital clock tooltip.

Martin Klapetek martin.klapetek at gmail.com
Sat Sep 27 21:40:41 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120358/#review67541
-----------------------------------------------------------

Ship it!


If the translators won't object, ship it from me while closing bug 337564. And thanks :)


applets/digital-clock/package/contents/ui/DigitalClock.qml
<https://git.reviewboard.kde.org/r/120358/#comment47083>

    "...current time in that zone"



applets/digital-clock/package/contents/ui/DigitalClock.qml
<https://git.reviewboard.kde.org/r/120358/#comment47082>

    Remove this empty space


- Martin Klapetek


On Sept. 27, 2014, 10:53 p.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120358/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2014, 10:53 p.m.)
> 
> 
> Review request for Plasma, Kai Uwe Broulik and Martin Klapetek.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> DigitalClock: Add timezone information to digital clock tooltip.
> 
> note: My editor is dumb and removed the umlaut from Sebas' name, I'll fix that before committing.
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 2beae00d090dfe03e94c4223ba36546ffeda45f2 
> 
> Diff: https://git.reviewboard.kde.org/r/120358/diff/
> 
> 
> Testing
> -------
> 
> I ran it here with two timezones selected (Local and London). The date is local date, but it was that way before anyway. The date next to each timezone is the date for that timezone if dates are shown.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140927/a2ee9c86/attachment.html>


More information about the Plasma-devel mailing list