Review Request 120358: DigitalClock: Add timezone information to digital clock tooltip.

Jeremy Whiting jpwhiting at kde.org
Sat Sep 27 20:38:14 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120358/
-----------------------------------------------------------

(Updated Sept. 27, 2014, 2:38 p.m.)


Review request for Plasma, Kai Uwe Broulik and Martin Klapetek.


Changes
-------

Moved tooltip code into a separate method to always call when datasource changes. Also call it initially to get the tooltip right at first launch.


Repository: plasma-workspace


Description
-------

DigitalClock: Add timezone information to digital clock tooltip.

note: My editor is dumb and removed the umlaut from Sebas' name, I'll fix that before committing.


Diffs (updated)
-----

  applets/digital-clock/package/contents/ui/DigitalClock.qml 2beae00d090dfe03e94c4223ba36546ffeda45f2 

Diff: https://git.reviewboard.kde.org/r/120358/diff/


Testing
-------

I ran it here with two timezones selected (Local and London). The date is local date, but it was that way before anyway. The date next to each timezone is the date for that timezone if dates are shown.


Thanks,

Jeremy Whiting

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140927/df0ae3e1/attachment.html>


More information about the Plasma-devel mailing list