Review Request 120390: Fix NotificatonPopup size

Kai Uwe Broulik kde at privat.broulik.de
Sat Sep 27 19:32:44 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120390/
-----------------------------------------------------------

(Updated Sept. 27, 2014, 7:32 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Martin Klapetek.


Repository: plasma-workspace


Description
-------

With the recent changes to the dialog class the sizing broke.
Using Layout.minimum{Width,Height} fixes the dialog not appearing.


Diffs
-----

  applets/notifications/package/contents/ui/NotificationPopup.qml 63036f1 

Diff: https://git.reviewboard.kde.org/r/120390/diff/


Testing
-------

Ran knotificationdbustest and everything works as expected again, both initial positioning as well as re-positioning due to a popup disappearing.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140927/7dc044f2/attachment-0001.html>


More information about the Plasma-devel mailing list