Review Request 120389: Fix collapsing panelcontroller buttons when they are too wide

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120389/
-----------------------------------------------------------

(Updated Sept. 27, 2014, 7:31 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Bugs: 338636
    https://bugs.kde.org/show_bug.cgi?id=338636


Repository: plasma-desktop


Description
-------

The reason why it was broken on my machine was that the placeholder label used a different translation domain than the actual buttons resulting in the placeholder having the much shorter english variants and thus it worked fine on other machines.

I now added three readonly properties with the button text for use in the placeholder and tooltips. Given that I just removed three broken translations and only moved strings around and other than that it's a straight-forward bugfix I guess it's for 5.1 too.


Diffs
-----

  desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml 5716405 

Diff: https://git.reviewboard.kde.org/r/120389/diff/


Testing
-------

Now in a horizontal panel the buttons are properly collapsed, tooltip appears on hovering. In vertical panel buttons have text (although that one is massive in German and the button gets wider than the window but that's out of this patch's scope)


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140927/00278905/attachment.html>