Review Request 120390: Fix NotificatonPopup size

[David Edmundson]

> On Sept. 27, 2014, 5 p.m., Martin Klapetek wrote:
> > Thanks for this
> > 
> > As gerrit mails do not get to plasma-devel (are they going anywhere else?), can I please ask people breaking things to send a short mail and/or fix all things? kthxbai

Login to gerrit, click settings, notifications.
kfgakjflsjdf


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120390/#review67529
-----------------------------------------------------------


On Sept. 27, 2014, 4:22 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120390/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2014, 4:22 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> With the recent changes to the dialog class the sizing broke.
> Using Layout.minimum{Width,Height} fixes the dialog not appearing.
> 
> 
> Diffs
> -----
> 
>   applets/notifications/package/contents/ui/NotificationPopup.qml 63036f1 
> 
> Diff: https://git.reviewboard.kde.org/r/120390/diff/
> 
> 
> Testing
> -------
> 
> Ran knotificationdbustest and everything works as expected again, both initial positioning as well as re-positioning due to a popup disappearing.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140927/4216bb76/attachment.html>