Review Request 120385: Cleanup system tray configuration

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120385/
-----------------------------------------------------------

(Updated Sept. 27, 2014, 10:39 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Bugs: 339428
    https://bugs.kde.org/show_bug.cgi?id=339428


Repository: plasma-workspace


Description
-------

This patch cleans up the system tray configuration a bit, it does:
 - Remove dead properties and runtime warnings of items that no longer exist or that I couldn't see being used
 - Use Array literal instead of new Array() or Array() which is faster
 - Use ColumnLayout instead of generic Column

And most importantly:
 - Emit configurationChanged signal when changing the ExtraItems because QML cannot detect changes that happen inside an Array. It can only detect when the whole property is assigned to something else - having a temp Array to push to and then assign would be a waste here, so I just emit the signal.

This patch does not, however, fix the apply button being broken when the dialog opens initially - my observations can be found in the related bug report.


Diffs
-----

  applets/systemtray/package/contents/ui/ConfigGeneral.qml 545ee32 

Diff: https://git.reviewboard.kde.org/r/120385/diff/


Testing
-------

Dialog looks the same, less warnings in the console and the apply button gets enabled when changing the extra items.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140927/88c1aaa0/attachment.html>