Review Request 120374: Fix system tray icons not always properly centered in vertical panel

[David Edmundson]

> On Sept. 26, 2014, 11:56 a.m., Marco Martin wrote:
> > this is incorrect, it breaks the icons layout in the systray popup

It doesn't /look/ broken here. Which part is messed up?


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120374/#review67482
-----------------------------------------------------------


On Sept. 26, 2014, 8:23 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120374/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2014, 8:23 a.m.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Under certain circumstances in a vertical panel the icons in the tray might not be centered horizontally. This patch fixes that both for status notifier items and applets while keeping fitt's law in place.
> 
> 
> Diffs
> -----
> 
>   applets/systemtray/package/contents/ui/StatusNotifierItem.qml aad91f1 
>   applets/systemtray/package/contents/ui/TaskDelegate.qml 5230599 
> 
> Diff: https://git.reviewboard.kde.org/r/120374/diff/
> 
> 
> Testing
> -------
> 
> Resized vertical panel, moved it around, expanded/collapsed, all seems to be working still.
> 
> 
> File Attachments
> ----------------
> 
> Before
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/09/25/6d7c5583-dd0a-4f8a-a9e0-de331f55c182__trayiconsbefore.png
> After
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/09/25/39f7ad29-3518-4d97-8d27-11c9e4dc1555__trayiconsafter.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140926/50f81348/attachment.html>