Review Request 120370: Make Battery Item behave like a regular IconItem

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120370/
-----------------------------------------------------------

(Updated Sept. 25, 2014, 5:57 nachm.)


Review request for Plasma.


Changes
-------

Use Math.min(parent.width, parent.height)


Repository: plasma-workspace


Description
-------

This patch makes the Battery Item behave like a regular IconItem by making it always square and rounding it to the nearest icon size. This way the icon in system tray looks like all the others.


Diffs (updated)
-----

  components/workspace/BatteryIcon.qml fbbf2af 

Diff: https://git.reviewboard.kde.org/r/120370/diff/


Testing
-------

System tray icon looks size-wise like the other icons (except NM, will look into this) and the bigger icons inside battery monitor look the same.


File Attachments
----------------

Uniform icon sizes
  https://git.reviewboard.kde.org/media/uploaded/files/2014/09/25/0712caf9-f9ef-4f95-9ab7-8fe5de5ae434__newiconsizes.png


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140925/5581b612/attachment.html>