Review Request 120358: DigitalClock: Add timezone information to digital clock tooltip.

Jeremy Whiting jpwhiting at kde.org
Thu Sep 25 17:49:08 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120358/
-----------------------------------------------------------

(Updated Sept. 25, 2014, 11:49 a.m.)


Review request for Plasma, Kai Uwe Broulik and Martin Klapetek.


Changes
-------

Updated timeForZone to be a bit cleaner in separating the two cases of showing line breaks or not (main ui, vs tooltip) Fixed other minor issues reported on reviewboard also.


Repository: plasma-workspace


Description
-------

DigitalClock: Add timezone information to digital clock tooltip.

note: My editor is dumb and removed the umlaut from Sebas' name, I'll fix that before committing.


Diffs (updated)
-----

  applets/digital-clock/package/contents/ui/DigitalClock.qml 00c9def8dffe1cdc24d377acab029b47bd57e602 

Diff: https://git.reviewboard.kde.org/r/120358/diff/


Testing
-------

I ran it here with two timezones selected (Local and London). The date is local date, but it was that way before anyway. The date next to each timezone is the date for that timezone if dates are shown.


Thanks,

Jeremy Whiting

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140925/bacef09a/attachment.html>


More information about the Plasma-devel mailing list