Review Request 120353: Add timezones i18n stuff

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120353/#review67430
-----------------------------------------------------------


Looks good to me from the i18n side, you can always use isEmpty in one of the maps instead instead a bool, but i'll leave that up to you.

- Albert Astals Cid


On set. 25, 2014, 3:12 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120353/
> -----------------------------------------------------------
> 
> (Updated set. 25, 2014, 3:12 p.m.)
> 
> 
> Review request for Localization and Translation (l10n) and Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> So in Plasma 5 we're adding support for timezones into the clock applet. It's based on QTimeZone and that uses IDs which are consisting of "Continent/City". Qt has no accessor methods for getting the city of the given timezone so we're parsing the timezone ID and using the part after "/" as the city and we display that in the UI.
> 
> We want those cities translated however so it can display eg. "Praha" instead of "Prague" for Czech users. So I've created this helper class which has a dictionary of timezone-id-city<-->i18n(city) and this is then used in the UI. I'm not sure where exactly to put it, I'd prefer KI18n framework but as we would like to have this in Plasma 5.1 release, I put it together with the applet as Plasma 5.1 does not (and probably will not) depend on KI18n 5.3.
> 
> I'm adding the l10n group to the reviewers - guys can you please comment/+1 this?
> 
> If this is deemed good enough, I'd like to also add the country and continent i18n functions into that class afterwards.
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml f26ba9f 
>   applets/digital-clock/plugin/CMakeLists.txt 1c11abe 
>   applets/digital-clock/plugin/digitalclockplugin.cpp f347ee9 
>   applets/digital-clock/plugin/timezonemodel.h e1f53c5 
>   applets/digital-clock/plugin/timezonemodel.cpp 1fbab09 
>   applets/digital-clock/plugin/timezonesi18n.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonesi18n.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120353/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140925/cdc2797c/attachment.html>