Review Request 120358: DigitalClock: Add timezone information to digital clock tooltip.

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120358/#review67406
-----------------------------------------------------------


Can you provide a screenshot of the tooltip?


applets/digital-clock/package/contents/ui/DigitalClock.qml
<https://git.reviewboard.kde.org/r/120358/#comment47049>

    Simple bindings can be written without braces and return:
    
    text: timeForZone(tzIndex, true)



applets/digital-clock/package/contents/ui/DigitalClock.qml
<https://git.reviewboard.kde.org/r/120358/#comment47050>

    ++i



applets/digital-clock/package/contents/ui/DigitalClock.qml
<https://git.reviewboard.kde.org/r/120358/#comment47048>

    This looks wrong to me. You are using the same format that is used in the clock itself for the tooltip?
    
    In 4.x the tooltip is:
    
    Thursday, 25 September 2014
    Berlin: 11:31
    London: 10:31
    Toronto: 4:31


- Kai Uwe Broulik


On Sept. 25, 2014, 2:12 vorm., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120358/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2014, 2:12 vorm.)
> 
> 
> Review request for Plasma, Kai Uwe Broulik and Martin Klapetek.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> DigitalClock: Add timezone information to digital clock tooltip.
> 
> note: My editor is dumb and removed the umlaut from Sebas' name, I'll fix that before committing.
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 00c9def8dffe1cdc24d377acab029b47bd57e602 
> 
> Diff: https://git.reviewboard.kde.org/r/120358/diff/
> 
> 
> Testing
> -------
> 
> I ran it here with two timezones selected (Local and London). The date is local date, but it was that way before anyway. The date next to each timezone is the date for that timezone if dates are shown.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140925/2bc34c77/attachment.html>